Changed several *_types properties to be optional due to STIX spec change #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be optional, due to a STIX spec change. Updated unit tests accordingly.
Codecov Report
@@ Coverage Diff @@
## master #355 +/- ##
==========================================
- Coverage 98.15% 98.15% -0.01%
==========================================
Files 124 124
Lines 14176 14175 -1
==========================================
- Hits 13914 13913 -1
Misses 262 262
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #335
This changes several properties which were formerly required, to be optional. Unit tests were updated too, where it seemed to be appropriate. Test changes were a judgement call, and not all object types had the same types of tests, so not all object type unit test suites seemed to need changes.