Fix issue 389

[khdesai]

No description provided.

[codecov-io]

Codecov Report

Merging #392 into master will decrease coverage by 0.00%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
- Coverage   98.45%   98.44%   -0.01%     
==========================================
  Files         127      127              
  Lines       14613    14613              
==========================================
- Hits        14387    14386       -1     
- Misses        226      227       +1     

Impacted Files	Coverage Δ
stix2/properties.py	98.41% <0.00%> (ø)
stix2/base.py	97.89% <100.00%> (ø)
stix2/test/v21/test_observed_data.py	100.00% <100.00%> (ø)
stix2/canonicalization/Canonicalize.py	61.04% <0.00%> (-0.41%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31cb2f8...998b4c0. Read the comment docs.

[rpiazza]

I had implemented this somewhat differently - Here is what I did:

   if properties_to_use:
        streamlined_object = {}
        if "hashes" in original_json_object and "hashes" in properties_to_use:
            possible_hash = choose_one_hash(original_json_object["hashes"])
            if possible_hash:
                streamlined_object["hashes"] = possible_hash
        for key in original_json_object.keys():
            if key in properties_to_use and key != "hashes":
                streamlined_object[key] = original_json_object[key]
        data = canonicalize(streamlined_object)

I think this makes more sense - because I think this is the way others would implement it.

What do you think?

[clenk]

Looks good to me; thanks @khdesai!