Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve problem with SSDEEP use in hashing-algorithm-ov #393

Merged
merged 2 commits into from
May 15, 2020

Conversation

emmanvg
Copy link
Contributor

@emmanvg emmanvg commented May 13, 2020

Eliminates problem in stix2 where an object using an ssdeep hash in 2.1 would use the lowercase variant. closes #391

@emmanvg emmanvg added this to the 2.0.0 milestone May 13, 2020
@emmanvg emmanvg requested a review from clenk May 13, 2020 22:20
@codecov-io
Copy link

codecov-io commented May 14, 2020

Codecov Report

Merging #393 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #393   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files         127      127           
  Lines       14613    14627   +14     
=======================================
+ Hits        14386    14400   +14     
  Misses        227      227           
Impacted Files Coverage Δ
stix2/patterns.py 99.33% <ø> (ø)
stix2/test/v21/test_pattern_expressions.py 100.00% <ø> (ø)
stix2/properties.py 98.42% <100.00%> (+<0.01%) ⬆️
stix2/test/v20/test_observed_data.py 100.00% <100.00%> (ø)
stix2/test/v21/test_observed_data.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 658e70b...b4dbc41. Read the comment docs.

@emmanvg
Copy link
Contributor Author

emmanvg commented May 14, 2020

@clenk I rebased, and build passed now...

Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @emmanvg!

@clenk clenk merged commit 33e07ed into oasis-open:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSDEEP Hashing algorithm case mismatch
3 participants