Change ObjectReferenceProperty to ReferenceProperty in 2.1 SCO classes #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to ReferenceProperty. Add a unit test to ensure that when a stix2 object is passed as a value of a ReferenceProperty, that the ID is properly pulled out and used as the actual property value, and that it doesn't affect the deterministic ID calculation.
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
==========================================
+ Coverage 98.31% 98.43% +0.12%
==========================================
Files 128 128
Lines 14394 14737 +343
==========================================
+ Hits 14152 14507 +355
+ Misses 242 230 -12
Continue to review full report at Codecov.
|
clenk
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #403
Also add a unit test to ensure that when a stix2 object is passed as a value of a ReferenceProperty of a 2.1 SCO, that the ID is properly pulled out and used as the actual property value, and that it doesn't affect the deterministic ID calculation.