-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Respect name of @Custom*
decorated defs
#439
Conversation
This is a fairly minor change but if you need a CLA signed, let me know. Thanks! |
Hi @maybe-sybr. Thank you for the submission, it's a good change. Would you mind fixing the unit tests though: https://travis-ci.org/github/oasis-open/cti-python-stix2/builds/712041095. If you're able to sign a CLA that would be awesome: https://www.oasis-open.org/resources/open-repositories/cla/individual-cla Thanks again! |
... if the object type hasn't been registered. Related: #439.
87f78b9
to
1534452
Compare
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
=======================================
Coverage 98.38% 98.39%
=======================================
Files 130 131 +1
Lines 14906 14942 +36
=======================================
+ Hits 14666 14702 +36
Misses 240 240
Continue to review full report at Codecov.
|
@clenk I've sent in a CLA, lmk if there are any issues. In the meantime, I've also fixed up those two unit tests which were failing and CI went green at https://travis-ci.org/github/oasis-open/cti-python-stix2/builds/712398792 . I did notice that the class names were only explicitly referenced for |
Thanks, @maybe-sybr your CLA's on file. Yes, it would be useful to have tests for these properties specifically. Properly wrapping the decorated class and passing up all of the attributes hasn't been a priority for us but would be an improvement. We'd accept any pull requests to that end, though! :) |
This change makes it easier to refer to
@Custom*
decorated classes programmatically.