Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CompositeDataSource and deduplicate() support for unversioned objects #444

Merged
merged 2 commits into from
Oct 15, 2020

Conversation

chisholm
Copy link
Contributor

Fixes #441 .

Update CompositeDataSource and deduplicate() to handle unversioned objects, including 2.1 SCOs.

objects, including 2.1 SCOs.  Updated some unit tests to test
this.  Fixed a typo in a 2.0 unit test (2.0 deduplicate() test).
@clenk
Copy link
Contributor

clenk commented Aug 19, 2020

Travis is failing: https://travis-ci.org/github/oasis-open/cti-python-stix2/jobs/719321125

Not sure why it's not showing up here on GitHub anymore.

@chisholm
Copy link
Contributor Author

I'm pretty sure the pattern_visitor.py and test_pattern_expression.py stuff is fixed in the pattern equivalence PR. If I fixed it here, there would be merge conflicts there. I fixed the missing comma in conftest.py though.

@maybe-sybr
Copy link
Contributor

#449 looks pretty big - is the expectation that it's good to go in now that it's up or would it be better to pull the lint fixes out and get master stable separately so this and other PRs can go in?

@emmanvg emmanvg added this to the 2.1.0 milestone Aug 28, 2020
@emmanvg
Copy link
Contributor

emmanvg commented Aug 28, 2020

@maybe-sybr I will rebase from master once the pre-commit fixes make it. We definitely want to make sure we are covering new code and tests.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2020

Codecov Report

Merging #444 into master will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
- Coverage   98.39%   98.25%   -0.15%     
==========================================
  Files         131      142      +11     
  Lines       14942    15728     +786     
==========================================
+ Hits        14702    15453     +751     
- Misses        240      275      +35     
Impacted Files Coverage Δ
stix2/datastore/__init__.py 100.00% <100.00%> (ø)
stix2/pattern_visitor.py 93.30% <100.00%> (+1.80%) ⬆️
stix2/patterns.py 99.35% <100.00%> (+<0.01%) ⬆️
stix2/test/v20/test_pattern_expressions.py 100.00% <100.00%> (ø)
stix2/test/v20/test_utils.py 100.00% <100.00%> (ø)
stix2/test/v21/conftest.py 100.00% <100.00%> (ø)
stix2/test/v21/test_datastore_composite.py 100.00% <100.00%> (ø)
stix2/test/v21/test_pattern_expressions.py 100.00% <100.00%> (ø)
stix2/test/v21/test_utils.py 100.00% <100.00%> (ø)
stix2/utils.py 98.33% <100.00%> (+1.66%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1948b38...3c25410. Read the comment docs.

@clenk clenk merged commit d17d01d into oasis-open:master Oct 15, 2020
@chisholm chisholm deleted the comp_ds_unversioned_objs branch October 15, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many datastores and helpers assume created and modified fields exist in objects
5 participants