-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Pagination in TAXII DataStore #480
Support Pagination in TAXII DataStore #480
Conversation
Codecov Report
@@ Coverage Diff @@
## master #480 +/- ##
==========================================
- Coverage 89.32% 89.31% -0.02%
==========================================
Files 144 144
Lines 16020 16034 +14
==========================================
+ Hits 14310 14320 +10
- Misses 1710 1714 +4
Continue to review full report at Codecov.
|
Just curious: would it make sense to add an as_pages() function for the 2.1 TAXII client, similar to the 2.0 client? It could be a nice convenience for 2.1 users and better align their APIs. |
I think so, that was one of my observations when making the changes. The second one being that some TAXII 2.0 Servers that claim pagination support are not providing the headers required to continue asking for pages making the client code to not behave with consistency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; thanks @emmanvg!
Proposed solution to solve the pagination issues.
Closes #479