acs conversion

[rpiazza]

No description provided.

[codecov-commenter]

Codecov Report

Merging #275 (08515f5) into master (85ed052) will decrease coverage by 0.22%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
- Coverage   68.22%   67.99%   -0.23%     
==========================================
  Files          19       20       +1     
  Lines        6564     6811     +247     
==========================================
+ Hits         4478     4631     +153     
- Misses       2086     2180      +94     

Impacted Files	Coverage Δ
stix2elevator/__init__.py	84.09% <ø> (ø)
stix2elevator/cli.py	0.00% <0.00%> (ø)
stix2elevator/convert_pattern.py	74.15% <50.00%> (-0.42%)	⬇️
stix2elevator/convert_to_acs.py	56.81% <56.81%> (ø)
stix2elevator/options.py	77.22% <60.00%> (-0.50%)	⬇️
stix2elevator/convert_stix.py	81.69% <80.00%> (+0.20%)	⬆️
stix2elevator/utils.py	89.90% <83.33%> (-0.25%)	⬇️
stix2elevator/missing_policy.py	25.09% <100.00%> (ø)
stix2elevator/test/test_idioms.py	74.60% <100.00%> (+2.02%)	⬆️
stix2elevator/test/test_main.py	100.00% <100.00%> (ø)
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85ed052...08515f5. Read the comment docs.

[clenk]

The ACS json schema says these are required properties: create_date_time, responsible_entity_custodian, policy_reference, control_set. If their STIX 1.x counterparts were required, should we give warnings about them being missing? If they weren't required in STIX 1.x are there default values we could use? In order to prevent outputting json that will fail to validate against the schema.

[clenk]

LGTM!

[emmanvg]

Suggested change

	cd["dervived_from"] = str(derivative_classification.derived_from)
	cd["derived_from"] = str(derivative_classification.derived_from)

[rpiazza]

good catch