Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the extra space in the Content-Type #95

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

2xyo
Copy link
Contributor

@2xyo 2xyo commented Feb 8, 2021

According to TAXII-2.1, there is no spaces between the media type and the version parameter : application/taxii+json;version=2.1.

This is not the case for TAXII-2.0 : application/vnd.oasis.taxii+json; version=2.0.

The section 3.1.1.1 of RFC7231, the following examples are all equivalent, but the first is preferred for consistency:

text/html;charset=utf-8
text/html;charset=UTF-8
Text/HTML;Charset="utf-8"
text/html; charset="utf-8"

Event if application/taxii+json;version=2.1 is equivalent to application/taxii+json; version=2.1, application/taxii+json;version=2.1 should be preferred.

@emmanvg
Copy link
Contributor

emmanvg commented Feb 10, 2021

Hi @2xyo, thanks for finding this! I think in the past you might have made contributions not related to functional code (documentation, configuration, etc.). This time around we might need you to sign the OASIS Individual CLA (https://www-legacy.oasis-open.org/resources/open-repositories/cla/individual-cla) in order to incorporate these changes. If you can't or don't want to, you can either close this PR or comment in this thread and I will incorporate these changes manually. Thanks!

@2xyo
Copy link
Contributor Author

2xyo commented Feb 10, 2021

CLA accepted :)

@emmanvg
Copy link
Contributor

emmanvg commented Feb 10, 2021

Forgot to mention this, but you can review if your submission went through here (https://www-legacy.oasis-open.org/resources/open-repositories/cla/view-individual). I was checking but could not find an entry with your GitHub username. If you already submitted the form, and cannot view your entry in the link I added here let me know.

@2xyo
Copy link
Contributor Author

2xyo commented Feb 10, 2021

Thanks @emmanvg , I Accepted the CLA on the website, then replied to the email from repository-cla@oasis-open.org (Wed, 10 Feb 2021 19:04:44 +0100) and the status of my demand is "approval pending" on https://www-legacy.oasis-open.org/node/5806

Copy link
Contributor

@emmanvg emmanvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @2xyo! Individual CLA on file and the changes look ok!

@emmanvg emmanvg merged commit 16a0f31 into oasis-open:master Feb 11, 2021
@emmanvg emmanvg added this to the 2.3.0 milestone Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants