Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ACL.annotations member #30

Closed
ghost opened this issue Sep 26, 2017 · 1 comment
Closed

Add ACL.annotations member #30

ghost opened this issue Sep 26, 2017 · 1 comment
Labels
CSD.1 Will be fixed in CSD.1. enhancement impact-non-breaking-change resolved-fixed

Comments

@ghost
Copy link

ghost commented Sep 26, 2017

Copied from sarif-standard/sarif-spec-v1#267, created by @michaelcfanning:

An ACL could include arbitrary source annotations, which consist of an array of messages + regions. This would allow squigglies + popups to be applied on clicking any arbitrary ACL.

In our proposal, we would assume that the regions are within the same file referenced in the ACL.location. Alternately, we could include a full PLC rather than a region.
@michaelcfanning michaelcfanning added the CSD.1 Will be fixed in CSD.1. label Feb 1, 2018
@ghost ghost self-assigned this Mar 6, 2018
@ghost
Copy link
Author

ghost commented Mar 6, 2018

@michaelcfanning We have already done this, but I failed to resolve and close the issue. I'll do that now.

@ghost ghost closed this as completed Mar 6, 2018
ghost pushed a commit that referenced this issue Jan 3, 2019
Update provisional agenda for TC #30
f428a9d
ghost pushed a commit that referenced this issue Feb 11, 2019
Update schema to TC #30, 2019-01-09.
fc27cb9
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CSD.1 Will be fixed in CSD.1. enhancement impact-non-breaking-change resolved-fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelcfanning