Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add a 'directory' role #322

Closed
michaelcfanning opened this issue Feb 12, 2019 · 1 comment
Closed

Please add a 'directory' role #322

michaelcfanning opened this issue Feb 12, 2019 · 1 comment
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-approved The TC approved the design and I can write the change draft design-improvement impact-non-breaking-change resolved-fixed

Comments

@michaelcfanning
Copy link
Contributor

We have determined that the newly renamed artifactLocation might usefully refer to a directory. we need a way to mark them in the newly renamed run.artifacts array.
ghost pushed a commit that referenced this issue Feb 18, 2019
Change draft for #322: 'directory' role.
e5ad529
@ghost ghost self-assigned this Feb 18, 2019
@ghost ghost added 2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. change-draft-available design-improvement labels Feb 18, 2019
ghost pushed a commit that referenced this issue Feb 20, 2019
Merge #322: "Add 'directory' role."
0eb3bef
@ghost ghost added impact-non-breaking-change resolved-fixed design-approved The TC approved the design and I can write the change draft and removed change-draft-available labels Feb 20, 2019
@ghost
Copy link

ghost commented Feb 20, 2019

Changes merged to provisional draft.

@ghost ghost closed this as completed Feb 20, 2019
ghost pushed a commit that referenced this issue Feb 20, 2019
#312, #322: Move change drafts to Accepted.
7238581
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-approved The TC approved the design and I can write the change draft design-improvement impact-non-breaking-change resolved-fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelcfanning