-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking item for minor adjustments to design and errata during spec authoring #342
Comments
The following errata were noted during the ballot period and will be corrected after the ballot closes:
|
@kupsch I made the changes you suggested. See §2.2 (Format examples), §3.10.3 (URIs that use the SARIF scheme), and §3.31.8 (logicalLocation kind property). @michaelcfanning All items are address so I'm resolving/closing this issue. |
Microsoft proposals the following incidental adjustments for clarity/consistency post TC33:
In Rename all 'instanceGuid' properties to 'guid' #341, we made the following additional changes for consistency in the removal of "instance" (see this comment for the full set of changes):
runAutomationDetails.instanceId
torunAutomationDetails.id
,.run.id
(of typerunAutomationDetails
) torun.automationDetails
. Otherwise we'd end up withrun.id.id
, where the firstid
is arunAutomationDetails
object and the second is a GUID-valued string. With this change, we end up withrun.automationDetails.id
, which reads naturally.Per @kupsch: Modify date-time format to allow a date without a time.
In Rename run.files to run.artifacts, fileLocation to artifactLocation #309 we made several more property and object name changes for consistency with "artifact". See this comment for the full set of changes.
In Converge all messages into a common format strings object #319, we created a
multiformatMessageString
object and converted somereportingDescriptor
properties to this type (fullDescription
andshortDescription
). We neglected to convertreportingDescriptor.help
to this type, however.The text was updated successfully, but these errors were encountered: