Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect statement of meaning of non-empty suppressions array #370

Closed
ghost opened this issue Apr 12, 2019 · 0 comments
Closed

Incorrect statement of meaning of non-empty suppressions array #370

ghost opened this issue Apr 12, 2019 · 0 comments
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. bug merged Changes merged into provisional draft. resolved-fixed

Comments

@ghost
Copy link

ghost commented Apr 12, 2019

Found by Ryley Taketa at MS.

Now that we have a suppression state "suppressionRejected", it is no longer true that a non-empty result.suppressions array means that the result is suppressed.
@ghost ghost added bug 2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. labels Apr 12, 2019
@ghost ghost self-assigned this Apr 12, 2019
@ghost ghost changed the title Incorrect statement of meaning of empty suppressions array Incorrect statement of meaning of non-empty suppressions array Apr 13, 2019
ghost pushed a commit that referenced this issue Apr 13, 2019
Change draft + merge for issues #366, #367, #368, #369, and #370.
5c92483
@ghost ghost added merged Changes merged into provisional draft. resolved-fixed labels Apr 13, 2019
@ghost ghost closed this as completed Apr 13, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. bug merged Changes merged into provisional draft. resolved-fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants