Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display EVM function name in verified contract calls #1565

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Oct 8, 2024

@lukaw3d lukaw3d changed the title Lw/evm name Display EVM function name in verified contract calls Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

Deployed to Cloudflare Pages

Latest commit: 13fa9df60e48cc0424392cca301184ed5894be43
Status:✅ Deploy successful!
Preview URL: https://616dc501.oasis-explorer.pages.dev
Alias: https://pr-1565.oasis-explorer.pages.dev

@@ -103,7 +103,7 @@ export const RuntimeTransactions: FC<TransactionsProps> = ({
...(verbose
? [
{
content: <RuntimeTransactionMethod method={transaction.method} truncate />,
content: <RuntimeTransactionMethod transaction={transaction} truncate />,
Copy link
Contributor

@buberdds buberdds Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks cool in details, but do we really want it in lists (where we present more general info) ?
Screenshot from 2024-10-08 18-34-13

cc: @donouwens

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw the names should be trimmed in the list, but trimming is buggy #1399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants