Rewrite ekiden runtime implementation (aka Fortanix SGX) #1531

kostko · 2019-03-14T13:03:06Z

Closes #1364
Closes #96
Closes #1022
Closes #1235
Closes #167
Closes #1260
Closes #1222
Closes #52
See #1000 (comment)
See #1318

TODO

Verify RAK binding in RPC sessions.
Extract MRENCLAVE from sgxs files (use sgxs crate).
Persist key manager root hash (currently into a file in node's datadir).
Make E2E tests pass.
Add cargo-elf2sgxs based on ftxsgx-runner-cargo from fortanix-sgx-tools (that one almost works, but runs the binary as well which is annoying).
Update README.
Check in Cargo.lock for better reproducibility.
Rebase on master.
Port over runtime-ethereum.

pro-wh

dumping comments from older version

pro-wh · 2019-03-14T19:18:02Z

client/src/transaction/client.rs

+    /// Dispatch a raw call to the node.
+    pub fn submit_tx_raw<C>(&self, call: C) -> BoxFuture<Vec<u8>>
+    where
+        C: Serialize,


if we were to serialize call outside this, either in call or an additional layer, would it save the compiler the trouble of emitting several specializations of this relatively large function?

kind of unbalanced that serializing call happens inside but deserializing the output happens outside

pro-wh · 2019-03-18T16:37:45Z

this PR also rearranges a lot of code. can you post a guide of what new code (roughly) corresponds to what old code?

kostko · 2019-03-18T16:55:17Z

this PR also rearranges a lot of code. can you post a guide of what new code (roughly) corresponds to what old code?

Sure. So roughly everything from common, storage, db, rpc, runtime (and maybe more) is now in runtime (the part that is used in the runtime implementation) and client (the client part for calling into runtimes). The worker is now runtime-loader. The key manager is now in keymanager-runtime (runtime) and keymanager-client (RPC client wrapper for the key manager).

kostko · 2019-03-18T17:04:58Z

The bigger change is that the IPC protocol now goes directly into the runtime instead of only to the worker. This means that some of the attestation stuff (AESM interaction) is now handled at the worker host.

pro-wh

dumping the day's comments

pro-wh · 2019-03-18T21:29:10Z

client/Cargo.toml

+ekiden-runtime = { path = "../runtime" }
+serde = "1.0.71"
+# TODO: Change to released version when 0.10.0 is released.
+serde_cbor = { git = "https://github.com/pyfisch/cbor", rev = "114ecaeac53799d0bf81ca8d1b980c7c419d76fe" }


ℹ️ pyfisch/cbor#88

This revision is just the master at a specific point in time. The important PR that we need is pyfisch/cbor#67.

pro-wh · 2019-03-18T21:32:51Z

client/src/lib.rs

+pub mod transaction;
+
+/// Boxed future type.
+pub type BoxFuture<T> = Box<futures::Future<Item = T, Error = failure::Error> + Send>;


(me) check if we do the same thing elsewhere

runtime/src/rpc/session.rs

client/src/rpc/client.rs

runtime/src/rpc/session.rs

client/src/rpc/client.rs

pro-wh · 2019-03-19T01:43:30Z

Yawning

First pass over the Go, I'll look over the rust changes in a bit.

Yawning · 2019-03-20T08:26:00Z

go/common/sgx/aesm/aesm.go

+	"github.com/oasislabs/ekiden/go/common/sgx/ias"
+)
+
+//go:generate protoc --go_out=. aesm_proto.proto


While I understand why this lives here, I'd rather it lived with all the other protobuf files.

go/common/sgx/aesm/aesm.go

go/ekiden/cmd/node/node.go

pro-wh

dumping today's comments

client/src/rpc/client.rs

Yawning · 2019-04-02T13:21:22Z

The OpenBSD project has songs for each release, this is the ekiden 0.3 one.

https://www.youtube.com/watch?v=xCGu5Z_vaps

Yawning

Yolo.

pro-wh

I'm also committed to maintaining this

pro-wh · 2019-04-05T00:50:32Z

runtime/src/rak.rs

+            None => return Err(RAKError::NotConfigured.into()),
+        };
+        let _authenticated_avr = avr::verify(&avr)?;
+        // TODO: Verify that the AVR has H(RAK) in report body.


ℹ️ downstream consumers will check our AVR. this would be a convenience sanity check

README.md

kostko mentioned this pull request Mar 14, 2019

Tracing go<->rust bridge #1525

Merged

kostko force-pushed the kostko/feature/fortanix-sgx branch 3 times, most recently from 610e937 to f8f1cf6 Compare March 18, 2019 14:14

kostko requested review from pro-wh, abukosek, Yawning, jberci, peterjgilbert and armaniferrante March 18, 2019 14:16

pro-wh reviewed Mar 18, 2019

View reviewed changes

kostko force-pushed the kostko/feature/fortanix-sgx branch from f8f1cf6 to baf8f27 Compare March 18, 2019 17:02

kostko force-pushed the kostko/feature/fortanix-sgx branch from baf8f27 to ab84ced Compare March 18, 2019 17:37

pro-wh reviewed Mar 19, 2019

View reviewed changes

kostko force-pushed the kostko/feature/fortanix-sgx branch 2 times, most recently from 59b6547 to ed07194 Compare March 19, 2019 17:26

Yawning reviewed Mar 20, 2019

View reviewed changes

kostko force-pushed the kostko/feature/fortanix-sgx branch 5 times, most recently from 5c97bb5 to e5449b2 Compare March 20, 2019 16:09

pro-wh reviewed Mar 21, 2019

View reviewed changes

client/src/rpc/client.rs Show resolved Hide resolved

kostko force-pushed the kostko/feature/fortanix-sgx branch 3 times, most recently from c41ad76 to 792af83 Compare March 21, 2019 13:50

kostko force-pushed the kostko/feature/fortanix-sgx branch from 843122c to 5128aa6 Compare April 2, 2019 12:24

kostko force-pushed the kostko/feature/fortanix-sgx branch 4 times, most recently from c881a7c to ed15809 Compare April 3, 2019 17:36

This was referenced Apr 4, 2019

Move client utilities from the testing folder into runtime-client #1514

Closed

Move (part of) client-utils into ekiden-runtime-client #1463

Closed

kostko force-pushed the kostko/feature/fortanix-sgx branch 3 times, most recently from 23b15c9 to c9ddbdc Compare April 4, 2019 11:09

Yawning approved these changes Apr 4, 2019

View reviewed changes

pro-wh approved these changes Apr 4, 2019

View reviewed changes

pro-wh reviewed Apr 5, 2019

View reviewed changes

kostko force-pushed the kostko/feature/fortanix-sgx branch 2 times, most recently from c4cc89a to 3e1a08f Compare April 5, 2019 13:18

peterjgilbert reviewed Apr 5, 2019

View reviewed changes

README.md Outdated Show resolved Hide resolved

armaniferrante reviewed Apr 5, 2019

View reviewed changes

README.md Show resolved Hide resolved

kostko force-pushed the kostko/feature/fortanix-sgx branch 4 times, most recently from 6a04d1c to 2e374db Compare April 8, 2019 09:04

kostko added 2 commits April 8, 2019 11:17

Rewrite ekiden runtime implementation

22a4e07

Commit Cargo.lock for better reproducibility

3ff39a5

kostko force-pushed the kostko/feature/fortanix-sgx branch from 2e374db to 3ff39a5 Compare April 8, 2019 09:18

kostko merged commit c0df8ca into master Apr 8, 2019

kostko mentioned this pull request Apr 11, 2019

Script to import key manager state from old data format #1590

Closed

kostko deleted the kostko/feature/fortanix-sgx branch May 9, 2019 09:38

This was referenced Aug 12, 2019

Use error-chain to define Ekiden errors #161

Closed

add libsgx-enclave-common to development image #1277

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rewrite ekiden runtime implementation (aka Fortanix SGX) #1531

Rewrite ekiden runtime implementation (aka Fortanix SGX) #1531

kostko commented Mar 14, 2019 •

edited

Loading

pro-wh left a comment

pro-wh Mar 14, 2019

pro-wh commented Mar 18, 2019

kostko commented Mar 18, 2019

kostko commented Mar 18, 2019

pro-wh left a comment

pro-wh Mar 18, 2019

kostko Mar 19, 2019

pro-wh Mar 18, 2019

pro-wh commented Mar 19, 2019 •

edited

Loading

Yawning left a comment

Yawning Mar 20, 2019

pro-wh left a comment

Yawning commented Apr 2, 2019

Yawning left a comment

pro-wh left a comment

pro-wh Apr 5, 2019

Rewrite ekiden runtime implementation (aka Fortanix SGX) #1531

Rewrite ekiden runtime implementation (aka Fortanix SGX) #1531

Conversation

kostko commented Mar 14, 2019 • edited Loading

pro-wh left a comment

Choose a reason for hiding this comment

pro-wh Mar 14, 2019

Choose a reason for hiding this comment

pro-wh commented Mar 18, 2019

kostko commented Mar 18, 2019

kostko commented Mar 18, 2019

pro-wh left a comment

Choose a reason for hiding this comment

pro-wh Mar 18, 2019

Choose a reason for hiding this comment

kostko Mar 19, 2019

Choose a reason for hiding this comment

pro-wh Mar 18, 2019

Choose a reason for hiding this comment

pro-wh commented Mar 19, 2019 • edited Loading

Yawning left a comment

Choose a reason for hiding this comment

Yawning Mar 20, 2019

Choose a reason for hiding this comment

pro-wh left a comment

Choose a reason for hiding this comment

Yawning commented Apr 2, 2019

Yawning left a comment

Choose a reason for hiding this comment

pro-wh left a comment

Choose a reason for hiding this comment

pro-wh Apr 5, 2019

Choose a reason for hiding this comment

kostko commented Mar 14, 2019 •

edited

Loading

pro-wh commented Mar 19, 2019 •

edited

Loading