Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/registry: Simplify creation of provisioners #5975

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

peternose
Copy link
Contributor

@peternose peternose commented Dec 17, 2024

Something is fishy with line config.GlobalConfig.Mode.IsClientOnly() && !isEnvSGX as it doesn't make sense. Do we run client with RuntimeEnvironmentELF and without DebugDontBlameOasis flag set?

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit 6ab9c9e
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/6760e97cd57fd70008895a9f

@peternose peternose force-pushed the peternose/trivial/simplify-create-provisioner branch from 80836f1 to f241f9d Compare December 17, 2024 01:46
@peternose peternose force-pushed the peternose/trivial/simplify-create-provisioner branch from f241f9d to 6ab9c9e Compare December 17, 2024 03:01
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.

Project coverage is 64.91%. Comparing base (6e6677d) to head (6ab9c9e).
Report is 31 commits behind head on master.

Files with missing lines Patch % Lines
go/runtime/registry/config.go 75.86% 3 Missing and 4 partials ⚠️
go/runtime/registry/registry.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5975      +/-   ##
==========================================
+ Coverage   64.68%   64.91%   +0.22%     
==========================================
  Files         629      632       +3     
  Lines       64299    64792     +493     
==========================================
+ Hits        41594    42057     +463     
+ Misses      17796    17792       -4     
- Partials     4909     4943      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptrus
Copy link
Member

ptrus commented Dec 17, 2024

Do we run client with RuntimeEnvironmentELF and without DebugDontBlameOasis flag set?

Yes I believe so: For example, running a ParaTime client node for an SGX-enabled ParaTime like Cipher doesn't require having SGX on the ParaTime client node..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants