-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contract-sdk: use C abi instead of wasm #548
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #548 +/- ##
==========================================
+ Coverage 71.94% 72.04% +0.09%
==========================================
Files 101 101
Lines 7097 7150 +53
==========================================
+ Hits 5106 5151 +45
- Misses 1969 1977 +8
Partials 22 22
Continue to review full report at Codecov.
|
kostko
reviewed
Oct 18, 2021
ptrus
force-pushed
the
ptrus/feature/wasm-abi-codegen
branch
from
October 19, 2021 07:11
3175203
to
c7d04e1
Compare
kostko
reviewed
Oct 19, 2021
kostko
reviewed
Oct 19, 2021
ptrus
force-pushed
the
ptrus/feature/wasm-abi-codegen
branch
2 times, most recently
from
October 20, 2021 07:28
9627f6e
to
1dac10d
Compare
ptrus
force-pushed
the
ptrus/feature/wasm-abi-codegen
branch
from
October 20, 2021 08:06
1dac10d
to
137b794
Compare
kostko
reviewed
Oct 20, 2021
kostko
reviewed
Oct 20, 2021
ptrus
force-pushed
the
ptrus/feature/wasm-abi-codegen
branch
6 times, most recently
from
October 21, 2021 07:03
a5251bd
to
7896fb2
Compare
kostko
approved these changes
Oct 21, 2021
ptrus
force-pushed
the
ptrus/feature/wasm-abi-codegen
branch
from
October 21, 2021 15:55
7896fb2
to
22697b8
Compare
kostko
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WASM abi seems quite broken, there are various problems with it:
Switch to using C abi. This requires modifying the exported functions to not use multivalue returns (which was only used for returning
HostRegion
s currently).