Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contract-sdk: use C abi instead of wasm #548

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Oct 18, 2021

The WASM abi seems quite broken, there are various problems with it:

Switch to using C abi. This requires modifying the exported functions to not use multivalue returns (which was only used for returning HostRegions currently).

@ptrus ptrus requested review from kostko and pro-wh as code owners October 18, 2021 12:36
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #548 (22697b8) into main (9ad3543) will increase coverage by 0.09%.
The diff coverage is 83.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
+ Coverage   71.94%   72.04%   +0.09%     
==========================================
  Files         101      101              
  Lines        7097     7150      +53     
==========================================
+ Hits         5106     5151      +45     
- Misses       1969     1977       +8     
  Partials       22       22              
Impacted Files Coverage Δ
contract-sdk/specs/oas20/contract/src/lib.rs 97.34% <ø> (ø)
contract-sdk/src/abi/dispatch.rs 0.00% <ø> (ø)
contract-sdk/src/abi/env.rs 0.00% <ø> (ø)
contract-sdk/src/abi/storage.rs 0.00% <ø> (ø)
contract-sdk/src/memory.rs 0.00% <0.00%> (ø)
runtime-sdk/modules/contracts/src/abi/oasis/mod.rs 64.81% <60.00%> (+0.05%) ⬆️
...ime-sdk/modules/contracts/src/abi/oasis/storage.rs 60.82% <66.66%> (ø)
...time-sdk/modules/contracts/src/abi/oasis/memory.rs 90.12% <92.50%> (+2.31%) ⬆️
runtime-sdk/modules/contracts/src/abi/oasis/env.rs 61.90% <100.00%> (-0.60%) ⬇️
...untime-sdk/modules/contracts/src/abi/oasis/test.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ad3543...22697b8. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/feature/wasm-abi-codegen branch from 3175203 to c7d04e1 Compare October 19, 2021 07:11
@ptrus ptrus force-pushed the ptrus/feature/wasm-abi-codegen branch 2 times, most recently from 9627f6e to 1dac10d Compare October 20, 2021 07:28
@ptrus ptrus force-pushed the ptrus/feature/wasm-abi-codegen branch from 1dac10d to 137b794 Compare October 20, 2021 08:06
@ptrus ptrus force-pushed the ptrus/feature/wasm-abi-codegen branch 6 times, most recently from a5251bd to 7896fb2 Compare October 21, 2021 07:03
@ptrus ptrus force-pushed the ptrus/feature/wasm-abi-codegen branch from 7896fb2 to 22697b8 Compare October 21, 2021 15:55
@ptrus ptrus enabled auto-merge October 21, 2021 16:06
@ptrus ptrus merged commit a43a5e6 into main Oct 21, 2021
@ptrus ptrus deleted the ptrus/feature/wasm-abi-codegen branch October 21, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants