fix(localnet): don't transition to epoch 3 #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/feature/startup-keymanager-epoch2
branch
4 times, most recently
from
25e9083 to
f039aae
Compare
ptrus
commented
Dec 17, 2024
docker/common/start.sh
Outdated
| fi | ||
|
|
||
| echo -n . | ||
| notice_debug -l "Setting epoch to 1..." | ||
| ${OASIS_NODE_BINARY} debug control set-epoch --epoch 1 -a unix:${OASIS_NODE_SOCKET} | ||
|
|
||
| # Transition to the next epoch when the KM generates ephemeral secret. | ||
| # Transition to the next epoch only when the keymanager has re-registered with updated extra_info. | ||
| # This ensures that we wait until the master secret has been generated and published. |
There was a problem hiding this comment.
Thanks to @peternose, we figured out the occasional remaining problem during the bootstrap. It was not sufficient to wait for ephemeral secret to be generated, but also that the master secrets are generated and published. We now do this by ensuring the KM re-registers with the updated extra_info.
ptrus
force-pushed
the
ptrus/feature/startup-keymanager-epoch2
branch
from
f039aae to
d6ed9f7
Compare
peternose
reviewed
Dec 17, 2024
| if [[ "${PARATIME_NAME}" == "sapphire" ]]; then | ||
| notice_debug -l "Waiting for key manager to generate ephemeral secret..." |
There was a problem hiding this comment.
You should still wait for ephemeral secret to be generated and proposed, as this is done concurrently. Although this will usually take less time than master secret generation and confirmation.
ptrus
force-pushed
the
ptrus/feature/startup-keymanager-epoch2
branch
4 times, most recently
from
e8345be to
fb331f7
Compare
ptrus
force-pushed
the
ptrus/feature/startup-keymanager-epoch2
branch
from
fb331f7 to
23db06b
Compare
peternose
approved these changes
Dec 17, 2024
ptrus
force-pushed
the
ptrus/feature/startup-keymanager-epoch2
branch
from
23db06b to
d56fb00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transitioning to epoch should be enough.
There remains one (very) occasional issue (which I cannot reliably reproduce), where requests to keymanager fail with:
Update: The above issue is now resolved as well.