Allow nested expressions in noGoogleTranslateCrashingSyntax

oasisprotocol · Aug 7, 2024 · 86adbe3 · 86adbe3
1 parent 4f7ce5f
commit 86adbe3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -14,7 +14,7 @@ const noGoogleTranslateCrashingSyntax = [
   {
     selector:
       'JSXElement > JSXExpressionContainer > LogicalExpression[operator="&&"]' +
-      ' > JSXFragment > .children:not(JSXElement, JSXText[value=/^\\s+$/])',
+      ' > JSXFragment > .children:not(JSXElement, JSXText[value=/^\\s+$/], JSXExpressionContainer)',
     message:
       '[b] Conditional plain text nodes could break React if used with Google Translate. Wrap text into an element.',
   },
@@ -47,7 +47,7 @@ const noGoogleTranslateCrashingSyntax = [
   {
     selector:
       'JSXElement > JSXExpressionContainer > ConditionalExpression' +
-      ' > JSXFragment > .children:not(JSXElement, JSXText[value=/^\\s+$/])',
+      ' > JSXFragment > .children:not(JSXElement, JSXText[value=/^\\s+$/], JSXExpressionContainer)',
     message:
       '[f] Conditional plain text nodes could break React if used with Google Translate. Wrap text into an element.',
   },

diff --git a/src/app/pages/AccountPage/Features/TransactionHistory/index.tsx b/src/app/pages/AccountPage/Features/TransactionHistory/index.tsx
@@ -96,13 +96,11 @@ export function TransactionHistory() {
               'Some transactions are currently in a pending state.',
             )}
           </AlertBox>
-          {/* eslint-disable no-restricted-syntax */}
           {!!pendingTransactionComponents.length && (
             <Box gap="medium" data-testid="pending-txs" margin={{ top: 'small' }}>
               {pendingTransactionComponents}
             </Box>
           )}
-          {/* eslint-enable no-restricted-syntax */}
         </>
       )}
       <Heading level="2">{t('account.summary.activity', 'Activity')}</Heading>

diff --git a/src/utils/eslint-test-noGoogleTranslateCrashingSyntax.tsx b/src/utils/eslint-test-noGoogleTranslateCrashingSyntax.tsx
@@ -40,6 +40,8 @@ const textBeforeAndOperator = (
       {!condition && <span>good</span>}
       {!condition && (
         <>
+          {/* good */}
+          {!condition && <span>good</span>}
           <span>good</span>
           <span>good</span>
         </>
@@ -167,6 +169,8 @@ const textInTernaryOperator = (
       {!condition ? <span>{good}</span> : <span>{good}</span>}
       {!condition ? (
         <>
+          {/* good */}
+          {!condition && <span>good</span>}
           <span>good</span>
           <span>good</span>
         </>