Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate BSC cancun support #84

Merged
merged 28 commits into from
Nov 13, 2024
Merged

Integrate BSC cancun support #84

merged 28 commits into from
Nov 13, 2024

Conversation

tak1827
Copy link
Contributor

@tak1827 tak1827 commented Oct 22, 2024

BSCのCancunに対応する実装をv1.4.15から取り込む。
対応する箇所の洗い出しとして次のPRを参照した

BSCとの相違点

  • sidecarsCacheLimitを1024から256に変更
  • Freezer.TableAncientsを追加しない。使っていないので。
  • BlobPool.validateTxの変更をとErrInBlackListを追加しない。BlackListがないので
  • OverrideDefaultExtraReserveForBlobRequests, OverrideBreatheBlockInterval, OverrideFixedTurnLengthは追加しない。テスト用なので
  • consensus.oasys.verifyHeaderはgo-ethereumとbscから取り込んだ
  • BSCのFreezer.offsetはゼロであるケースが多そう。なので、取り込むときに無視した。

@tak1827 tak1827 requested a review from ironbeer October 23, 2024 12:42
core/blockchain.go Outdated Show resolved Hide resolved
Base automatically changed from feat/v1.13.15-compile to feat/v1.13.15 November 6, 2024 03:25
ironbeer and others added 4 commits November 6, 2024 11:27
Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com>
Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com>
llamapreview[bot]

This comment was marked as off-topic.

@tak1827 tak1827 requested a review from ironbeer November 6, 2024 04:28
llamapreview[bot]

This comment was marked as off-topic.

params/config.go Outdated Show resolved Hide resolved
ironbeer and others added 2 commits November 6, 2024 14:01
Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com>
@tak1827 tak1827 requested a review from ironbeer November 6, 2024 06:04
llamapreview[bot]

This comment was marked as off-topic.

ironbeer
ironbeer previously approved these changes Nov 12, 2024
@ironbeer ironbeer dismissed their stale review November 12, 2024 09:57

要検討箇所を見つけたのでdismiss

consensus/oasys/oasys.go Outdated Show resolved Hide resolved
ironbeer
ironbeer previously approved these changes Nov 13, 2024
@ironbeer ironbeer dismissed their stale review November 13, 2024 09:54

操作ミス

Co-authored-by: ironbeer <7997273+ironbeer@users.noreply.github.com>
@tak1827 tak1827 merged commit 35b4084 into feat/v1.13.15 Nov 13, 2024
@tak1827 tak1827 deleted the feat/v1.13.15-bsc branch November 13, 2024 14:29
@tak1827 tak1827 restored the feat/v1.13.15-bsc branch November 13, 2024 14:57
@tak1827 tak1827 deleted the feat/v1.13.15-bsc branch November 13, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants