Feature iframe permissions #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 5cb47d9)
wazelin
requested review from
kilatib,
poyuki,
olga-kulish,
oatymart and
taopkorczak
poyuki
approved these changes
Jul 19, 2023
…microphone` in iframe ResourceLink
wazelin
force-pushed
the
feature/iframe-permissions
branch
from
ac76630 to
bc942e8
Compare
oatymart
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Works as intended, super!
- New code is respecting code style rules
- New code is respecting best practices
- Feature is working correctly on my local machine (if applicable)
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Changelog is updated according to changes (if applicable)
kilatib
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Changelog is updated according to changes (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the ResourceLink to benefit from
autoplay,camera,display-capture,fullscreen,microphonepermissions.