Fix/tao 5505/tts cannot click to speak choice content #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… was enabled but not released on clicking at answer when click-to-speak was activated)
ssipasseuth
reviewed
Jan 31, 2018
| } else { | ||
| if (self.getOption && self.getOption("enableDragAndDrop") && self.getOption("enableDragAndDrop").associate) { | ||
| isDragAndDropEnabled = self.getOption("enableDragAndDrop").associate; | ||
| } |
There was a problem hiding this comment.
It would be better to avoid repeating the same piece of code multiple time whenever possible by wrapping this into a function like self.isDragAndDropEnabled(). Could you add it into a function that will make the code easier to read. Also you can save one code block level by directly assignation like else { isDragAndDropEnabled = self.isDragAndDropEnabled()}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for bug with click-to-speak and associate interactions (drag&drop was enabled but not released on clicking at answer when click-to-speak was activated)