-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add form modifiers #2571
Merged
gabrielfs7
merged 12 commits into
feat/HKD-6/integration
from
feature/ADF-1780/create-necessary-metadata
Sep 13, 2024
Merged
chore: add form modifiers #2571
gabrielfs7
merged 12 commits into
feat/HKD-6/integration
from
feature/ADF-1780/create-necessary-metadata
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end summary Node 18
|
This was referenced Sep 10, 2024
shpran
commented
Sep 11, 2024
Comment on lines
+69
to
+71
"oat-sa/tao-core": "dev-feat/ADF-1781/translations-feature as 99.99", | ||
"oat-sa/extension-tao-item": "dev-feat/ADF-1779/add-translator-role as 99.99", | ||
"oat-sa/extension-tao-test": "dev-feat/ADF-1779/add-translator-role as 99.99" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Update composer dependencies
gabrielfs7
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shpran
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
shpran
force-pushed
the
feature/ADF-1780/create-necessary-metadata
branch
from
September 11, 2024 13:43
5bcad6c
to
a729df0
Compare
1 task
gabrielfs7
reviewed
Sep 12, 2024
gabrielfs7
reviewed
Sep 12, 2024
gabrielfs7
reviewed
Sep 12, 2024
gabrielfs7
reviewed
Sep 12, 2024
Version
There are 0 BREAKING CHANGE, 0 feature, 0 fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://oat-sa.atlassian.net/browse/ADF-1779
https://oat-sa.atlassian.net/browse/ADF-1780
https://oat-sa.atlassian.net/browse/ADF-1781
https://oat-sa.atlassian.net/browse/ADF-1783
Changes
TODO
PRs