-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ADF-1784/Side by side authoring #2585
Feature/ADF-1784/Side by side authoring #2585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, works well and looks good.
Nice job!
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
controller/QtiCreator.php
Outdated
// TODO: better implement the following parameters | ||
// --- start | ||
$config->setProperty('translation', $this->getRequestParameter('translation')); | ||
$config->setProperty('origin', $this->getRequestParameter('originResourceUri')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me, thanks. My personal preference, which is not a must here is to use the originResourceUri
instead of origin
, to make it more explicit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM the BE part. Thanks!
Related to: https://oat-sa.atlassian.net/browse/ADF-1784
Summary
Add the side-by-side UI in the item authoring when translating.
Details
Add support for:
Note: the server side may need to be refactored as it is fast approach.
How to test
git checkout -t origin/feature/ADF-1784/side-by-side-authoring