Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ADF-1784/Side by side authoring #2585

Merged

Conversation

jsconan
Copy link
Contributor

@jsconan jsconan commented Oct 10, 2024

Related to: https://oat-sa.atlassian.net/browse/ADF-1784

Summary

Add the side-by-side UI in the item authoring when translating.

image

Details

Add support for:

  • opening an item for translation: side-by-side UI

Note: the server side may need to be refactored as it is fast approach.

How to test

  • checkout the branch: git checkout -t origin/feature/ADF-1784/side-by-side-authoring
  • also make sure to checkout the companion PRs
  • make sure to have the Feature Flags activated
FEATURE_FLAG_TRANSLATION_ENABLED=true
FEATURE_FLAG_UNIQUE_NUMERIC_QTI_IDENTIFIER=true
FEATURE_FLAG_TRANSLATION_DEVELOPER_MODE=true
  • make sure to have the Item Translator role assigned to your user
  • have an item ready for translation and add/edit a translation: it should present the side-by-side authoring
  • from a regular item, also open the authoring: it should present the usual authoring

Copy link
Contributor

@shaveko shaveko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works well and looks good.

Nice job!

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

// TODO: better implement the following parameters
// --- start
$config->setProperty('translation', $this->getRequestParameter('translation'));
$config->setProperty('origin', $this->getRequestParameter('originResourceUri'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, thanks. My personal preference, which is not a must here is to use the originResourceUri instead of origin, to make it more explicit

@jsconan jsconan requested a review from gabrielfs7 October 14, 2024 08:54
Copy link
Contributor

@gabrielfs7 gabrielfs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM the BE part. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants