Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple hottext support when disallowHTMLInHottext is enabled #2651

Conversation

viktar-dzmitryieu-tao
Copy link
Contributor

@viktar-dzmitryieu-tao viktar-dzmitryieu-tao commented Dec 18, 2024

Ticket: https://oat-sa.atlassian.net/browse/AUT-3890

What's Changed

  • Added support for multiple hottext when disallowHTMLInHottext is enabled

How to test

  • Enable FF disallowHTMLInHottext
  • Create an Item and add hottext interaction to it
  • Select the text
  • Click multiple hottext button
  • The words should be selected separately, divided by the space in selection

The changes are deployed to https://construct1-oat-unit04.dev.gcp-eu.taocloud.org/tao/Main/login
The FF is enabled there

Copy link

Version

Target Version 30.25.3
Last version 30.25.2

There are 0 BREAKING CHANGE, 0 feature, 1 fix

Copy link

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
287 287 0 0

@viktar-dzmitryieu-tao viktar-dzmitryieu-tao requested review from a team, tikhanovichA, KirylHatalski and Karol-Stelmaczonek and removed request for a team December 19, 2024 13:26
Copy link
Contributor

@Karol-Stelmaczonek Karol-Stelmaczonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

@viktar-dzmitryieu-tao viktar-dzmitryieu-tao merged commit 13c4026 into develop Dec 20, 2024
5 checks passed
@viktar-dzmitryieu-tao viktar-dzmitryieu-tao deleted the fix/AUT-3890/multiple-hottext-when-disallowhtmlinhottext-enabled branch December 20, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants