Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add userpilot to TAO 3.x, save tenant id as session context #400

Merged
merged 6 commits into from
Mar 19, 2024

Conversation

pribi
Copy link
Contributor

@pribi pribi commented Mar 6, 2024

Ticket: https://oat-sa.atlassian.net/browse/MS-2756

What's Changed

  • Added UserPilot to TAO 3.x.

TODO

  • Unit tests
  • E2E tests
  • Update composer with packages

Dependencies PRs

How to test

  • Install TAO Portal and TAO 3.x Authoring using NGS.
  • cd nextgen-stack/tao
  • composer require "oat-sa/extension-tao-lti":"dev-feature/MS-2756/add-userpilot-to-tao-3.x as 15.15.1" "oat-sa/tao-core":"dev-feature/MS-2756/add-userpilot-to-tao-3.x as 54.4.1"
  • Setup TAO Portal - Authoring simplification
  • Login to TAO Portal
  • Go to Authoring by clicking on Content Bank
  • Inspect source code

Screenshots

image

@pribi pribi marked this pull request as draft March 6, 2024 14:49
@pribi pribi marked this pull request as ready for review March 7, 2024 14:36
@viktar-dzmitryieu-tao
Copy link

should it point to develop branch instead?

composer.json Outdated Show resolved Hide resolved
Copy link
Contributor

@andreluizmachado andreluizmachado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, please just do not forget to change the target branch. It should be develop, not master

@pribi pribi changed the base branch from master to develop March 8, 2024 12:12
Copy link
Contributor

@Karol-Stelmaczonek Karol-Stelmaczonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

Copy link
Contributor

@SultanSagi SultanSagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 31.32%. Comparing base (8168f6e) to head (f1c0534).

Files Patch % Lines
models/classes/LtiService.php 0.00% 15 Missing ⚠️
models/classes/TaoLtiSession.php 0.00% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #400      +/-   ##
=============================================
- Coverage      31.47%   31.32%   -0.15%     
- Complexity       841      842       +1     
=============================================
  Files            106      106              
  Lines           2939     2953      +14     
=============================================
  Hits             925      925              
- Misses          2014     2028      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Version

Target Version 15.18.0
Last version 15.17.0

There are 0 BREAKING CHANGE, 5 features, 0 fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants