-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add userpilot to TAO 3.x, save tenant id as session context #400
Conversation
should it point to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, please just do not forget to change the target branch. It should be develop, not master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
…ient id is not available
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #400 +/- ##
=============================================
- Coverage 31.47% 31.32% -0.15%
- Complexity 841 842 +1
=============================================
Files 106 106
Lines 2939 2953 +14
=============================================
Hits 925 925
- Misses 2014 2028 +14 ☔ View full report in Codecov by Sentry. |
Version
There are 0 BREAKING CHANGE, 5 features, 0 fix |
Ticket: https://oat-sa.atlassian.net/browse/MS-2756
What's Changed
TODO
Dependencies PRs
How to test
Screenshots