Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra space on remove the mainClass #444

Merged

Conversation

marpesia
Copy link
Contributor

Related to #441

Remove extra space on the replace action to avoid keeping 2 blank spaces.

@marpesia marpesia requested a review from bziondik October 25, 2022 10:26
@github-actions
Copy link

Version

Target Version 12.33.4
Last version 12.33.3

There are 0 BREAKING CHANGE, 0 feature, 1 fix

Copy link
Contributor

@bziondik bziondik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

Copy link
Contributor

@Silvia-loza Silvia-loza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • Pull request's target is not master
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

@marpesia marpesia merged commit c530213 into develop Oct 25, 2022
@marpesia marpesia deleted the fix/AUT-2637/remove-extra-space-mainClass-from-old-selectors branch October 25, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants