Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature AUT-3769 center images horizontally in QTI Item Creator #599

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

wazelin
Copy link
Member

@wazelin wazelin commented Jul 30, 2024

AUT-3769

This PR

  1. Adds the new align-center icon
  2. Allows to center an image via QTI Item Creator
image image

@wazelin wazelin requested a review from olga-kulish July 30, 2024 12:43
Copy link

github-actions bot commented Jul 30, 2024

Coverage Report

Totals Coverage
Statements: 76.99% ( 14346 / 18634 )
Methods: 80.38% ( 1815 / 2258 )
Lines: 81.52% ( 8587 / 10534 )
Branches: 67.51% ( 3944 / 5842 )

StandWithUkraine

@wazelin wazelin force-pushed the feature/AUT-3769/support-centered-image branch from 566255e to c5f2c45 Compare July 30, 2024 12:43
Copy link
Contributor

@olga-kulish olga-kulish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve once whole Authoring flow is ready.

To apply this class in test-runner, add it here: https://github.com/oat-sa/tao-deliver-fe/blob/main/packages/item-runner/src/runner/item/Item.svelte#L638-L645

scss/inc/_base.scss Outdated Show resolved Hide resolved
@wazelin wazelin force-pushed the feature/AUT-3769/support-centered-image branch from c5f2c45 to b5f2e4b Compare July 31, 2024 08:25
@wazelin wazelin force-pushed the feature/AUT-3769/support-centered-image branch 6 times, most recently from 5181427 to 59121ca Compare July 31, 2024 09:25
@wazelin wazelin force-pushed the feature/AUT-3769/support-centered-image branch from 59121ca to 9f677ff Compare July 31, 2024 09:32
@wazelin wazelin changed the title feat: add support for .center base selector that would center an element horizontally feat: add support for .tao-centered base selector that would center an element horizontally Jul 31, 2024
@wazelin wazelin changed the title feat: add support for .tao-centered base selector that would center an element horizontally Feature AUT-3769 center images horizontally in QTI Item Creator Jul 31, 2024
@olga-kulish olga-kulish self-requested a review August 1, 2024 19:33
Copy link

github-actions bot commented Aug 1, 2024

Version

Target Version 3.6.0
Last version 3.5.0

There are 0 BREAKING CHANGE, 3 features, 1 fix

@wazelin wazelin merged commit 43f898a into develop Aug 2, 2024
3 checks passed
@wazelin wazelin deleted the feature/AUT-3769/support-centered-image branch August 2, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants