Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow recursive configurable services #2523

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

jbout
Copy link
Contributor

@jbout jbout commented May 28, 2020

Allow nested configurable services in configurable services

@jbout jbout marked this pull request as draft May 28, 2020 07:21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-ionut-mihai-sandu-tao
Copy link
Contributor

mike-ionut-mihai-sandu-tao commented Jun 4, 2020

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

@mike-ionut-mihai-sandu-tao
Copy link
Contributor

we need tests for this ,
but my local test included the following setup

"configuration": {
    "global": {
      "lang": "en-US",
      "mode": "debug",
      "instance_name": "tao",
      "namespace": "https://premium.docker.localhost/ontologies/tao.rdf",
      "url": "https://premium.docker.localhost/",
      "session_name": "tao",
      "timezone": "Europe/Luxembourg",
      "import_data": true
    },
    "generis": {
      "ontology": {
        "type": "configurableService",
        "class": "oat\\generis\\model\\kernel\\persistence\\newsql\\NewSqlOntology",
        "options": {
          "persistence": "default",
          "readable": [
            1,
            2
          ],
          "writeable": [
            1
          ],
          "addTo": 1,
          "search": "generis\/complexSearch",
          "cache": "generis\/cache"
        }
      },
      "persistences": {
        "default": {
          "driver": "pdo_mysql",
          "host": "tao_premium73_mariadb",
          "port": 3306,
          "dbname": "premium",
          "user": "premium",
          "password": "premium"
        },
        "redis": {
          "driver": "phpredis",
          "host": "tao_premium73_redis",
          "port": 6379
        },
        "default_kv": {
          "driver": "phpredis",
          "host": "tao_premium73_redis",
          "port": 6379
        },
        "authKeyValue": {
          "driver": "phpredis",
          "host": "tao_premium73_redis",
          "port": 6379
        },
        "keyValueResult": {
          "driver": "phpredis",
          "host": "tao_premium73_redis",
          "port": 6379
        }
      },
      "log": {
        "type": "configurableService",
        "class": "oat\\oatbox\\log\\LoggerService",
        "options": {
          "logger": {
            "class": "oat\\oatbox\\log\\logger\\TaoMonolog",
            "options": {
              "handlers": [
                {
                  "class": "Monolog\\Handler\\StreamHandler",
                  "options": [
                    "backofficeplus-log.log"
                  ]
                }
              ]
            }
          }
        }
      },
      "tao": {
        "session": {
          "type": "configurableService",
          "class": "\\common_session_php_KeyValueSessionHandler",
          "options": {
            "persistence": "redis"
          }
        }
      },
      "notification": {
        "type": "configurableService",
        "class": "\\oat\\tao\\model\\notification\\implementation\\NotificationServiceAggregator",
        "options": {
          "rds": {
            "class": "\\oat\\tao\\model\\notification\\implementation\\NewSqlNotificationService",
            "options": {
              "persistence": "default",
              "visibility": false
            }
          }
        }
      },
      "webhookLogRepository": {
        "type": "configurableService",
        "class": "oat\\tao\\model\\webhooks\\log\\NewSqlWebhookLogRepository",
        "options": {
          "persistence": "default"
        }
      }
    },
    "taoOutcomeRds": {
      "RdsResultStorage": {
        "type": "configurableService",
        "class": "\\oat\\taoOutcomeRds\\model\\NewSqlResultStorage",
        "options": {
          "persistence": "default"
        }
      }
    },
    "taoRevision": {
      "repository": {
        "type": "configurableService",
        "class": "oat\\taoRevision\\model\\RepositoryService",
        "options": {
          "storage": {
            "type": "configurableService",
            "class": "oat\\taoRevision\\model\\storage\\NewSqlStorage",
            "options": {
              "persistence": "default"
            }
          },
          "filesystem": "revisions"
        }
      }
    }
  },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants