Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test:fix compatibility to php7.2 #3385

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

test:fix compatibility to php7.2 #3385

wants to merge 2 commits into from

Conversation

siwane
Copy link
Collaborator

@siwane siwane commented Feb 3, 2022

Fix compatibility to php 7.2

@siwane siwane requested review from alroniks and gabrielfs7 February 3, 2022 07:57
gabrielfs7
gabrielfs7 approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@gabrielfs7 gabrielfs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💯

@siwane siwane force-pushed the fix/REL-615/fix-php-compatibility branch from cd35b47 to 76b290b Compare February 3, 2022 08:07
@github-actions
Copy link

github-actions bot commented Feb 3, 2022

Version

❕ Some commits are not using the conventional commits formats. They will be ignored in version management.

Target Version 49.1.1
Last version 49.1.0

There are 0 BREAKING CHANGE, 0 feature, 1 fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielfs7 gabrielfs7 gabrielfs7 approved these changes

@alroniks alroniks alroniks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siwane @alroniks @gabrielfs7