Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/AUT-2673/inline-figure-img #3676

Merged
merged 14 commits into from
Nov 28, 2022
Merged

Conversation

marpesia
Copy link
Contributor

@marpesia marpesia commented Nov 16, 2022

Related to: AUT-2673

Description:
Display Image inline on Figure tag

Changes:

Companion extensions:

How to check:

On Assets

  • Create an Asset with a text block. Add in the middle of the text an image. Play with the inline panel controls of the image to check if it is positioned correctly.
  • Check Preview.

On Items

  • Create an Item with a text block. Add in the middle of the text an image. Play with the inline panel controls of the image to check if it is positioned correctly.
  • Add the previously created Asset with the Figure image on the inline position to check the position of the Asset image inside the Item.
  • Check Preview

On Tests

  • Check Terre Preview
  • Delivery Terre

Check a test on Delivery.

Copy link
Contributor

@jsconan jsconan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code check only.
It looks good.

@codecov-commenter
Copy link

Codecov Report

Merging #3676 (920def6) into develop (9b0f54c) will increase coverage by 0.46%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #3676      +/-   ##
=============================================
+ Coverage      26.15%   26.62%   +0.46%     
- Complexity     10683    10704      +21     
=============================================
  Files            899      896       -3     
  Lines          29075    28432     -643     
=============================================
- Hits            7605     7570      -35     
+ Misses         21470    20862     -608     
Impacted Files Coverage Δ
models/classes/routing/RouteAnnotationService.php 69.44% <0.00%> (-1.61%) ⬇️
models/classes/accessControl/PermissionChecker.php 83.33% <0.00%> (-0.88%) ⬇️
helpers/class.Display.php 60.00% <0.00%> (-0.79%) ⬇️
...Business/Validation/DependsOnPropertyValidator.php 69.04% <0.00%> (-0.72%) ⬇️
...dels/classes/accessControl/ActionAccessControl.php 82.66% <0.00%> (-0.67%) ⬇️
...classes/import/service/RdsValidatorValueMapper.php 88.23% <0.00%> (-0.66%) ⬇️
...a/Import/Validator/MetadataPropertiesValidator.php 73.91% <0.00%> (-0.56%) ⬇️
...ticalMetadata/Import/Processor/ImportProcessor.php 76.08% <0.00%> (-0.51%) ⬇️
.../session/Business/Service/SessionCookieService.php 94.73% <0.00%> (-0.51%) ⬇️
models/classes/Tree/GetTreeRequest.php 70.00% <0.00%> (-0.50%) ⬇️
... and 282 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@bziondik bziondik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on playground (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

Copy link
Contributor

@Silvia-loza Silvia-loza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • Pull request's target is not master
  • Feature is working correctly on kitchen env (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

@github-actions
Copy link

Version

Target Version 50.27.2
Last version 50.27.1

There are 0 BREAKING CHANGE, 0 feature, 2 fixes

@bziondik bziondik merged commit 8cf0ba5 into develop Nov 28, 2022
@bziondik bziondik deleted the fix/AUT-2673/inline-figure-img branch November 28, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants