feat: Custom config for testing PHP-MD codesize rules in the pipelines #3827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectoras
commented
May 29, 2023
Comment on lines
-117
to
-119
| $parameter->isVariadic() | ||
| ? yield from $value | ||
| : yield $value; |
There was a problem hiding this comment.
The former syntax breaks the php-md parser
Version
There are 0 BREAKING CHANGE, 1 feature, 0 fix |
Codecov Report
@@ Coverage Diff @@
## develop #3827 +/- ##
=============================================
+ Coverage 28.12% 28.13% +0.01%
- Complexity 10880 10952 +72
=============================================
Files 915 922 +7
Lines 32660 32912 +252
=============================================
+ Hits 9185 9260 +75
- Misses 23475 23652 +177
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE.
For testing/debugging purposes.