[AUT-3941] Quick wins redesign #4143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end summary Node 18
|
KirylHatalski
changed the title
KirylHatalski
requested review from
jsconan,
tikhanovichA,
Karol-Stelmaczonek and
viktar-dzmitryieu-tao
tikhanovichA
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Tested locally
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
- Changelog is updated according to changes (if applicable)
- Documentation is updated according to changes (if applicable)
KirylHatalski
force-pushed
the
feat/AUT-3941/quick-wins-redesign
branch
from
feaea7a to
cebb942
Compare
KirylHatalski
force-pushed
the
feat/AUT-3941/quick-wins-redesign
branch
from
cebb942 to
9907acb
Compare
KirylHatalski
force-pushed
the
feat/AUT-3941/quick-wins-redesign
branch
from
9907acb to
8b82e7a
Compare
KirylHatalski
force-pushed
the
feat/AUT-3941/quick-wins-redesign
branch
from
8b82e7a to
68d6091
Compare
KirylHatalski
force-pushed
the
feat/AUT-3941/quick-wins-redesign
branch
from
68d6091 to
2a9be37
Compare
jsconan
reviewed
Dec 19, 2024
views/templates/blocks/logout.tpl
Outdated
Comment on lines
5
to
9
| <?php if(Layout::isQuickWinsDesignEnabled()): ?> | ||
| <li data-env="user" class="li-logout"> | ||
| <?php else: ?> | ||
| <li data-env="user" class="li-logout<?php if(!empty($userLabel) && print ' sep-before')?>"> | ||
| <?php endif; ?> |
There was a problem hiding this comment.
suggestion: A good habit is to leave the place in a better shape than it was before. Rather that adding complexity, consider simplifying and improving.
Suggested change
| <?php if(Layout::isQuickWinsDesignEnabled()): ?> | |
| <li data-env="user" class="li-logout"> | |
| <?php else: ?> | |
| <li data-env="user" class="li-logout<?php if(!empty($userLabel) && print ' sep-before')?>"> | |
| <?php endif; ?> | |
| <li data-env="user" class="li-logout<?= !empty($userLabel) && !Layout::isQuickWinsDesignEnabled() ? ' sep-before' : '' ?>"> |
| <?php if(!Layout::isQuickWinsDesignEnabled()): ?> | ||
| <img src="<?=$releaseMsgData['logo']?>" alt="TAO Logo" id="tao-main-logo"/> | ||
| <?php else: ?> | ||
| <svg xmlns="http://www.w3.org/2000/svg" width="75" height="47" viewBox="0 0 75 47" fill="none" id="tao-main-logo"> |
There was a problem hiding this comment.
question: Why not use a file instead? Inline images make the code heavy, and it should only be used when no other choice exists.
There was a problem hiding this comment.
Moved to file and pathed via BE
| @@ -276,3 +276,346 @@ | |||
| body.oversized-nav:not(.delivery-scope) { | |||
| @include mobile-search(); | |||
| } | |||
|
|
|||
|
|
|||
| body.qc-wins { | |||
There was a problem hiding this comment.
suggestion: A better approach would be to create another set of SCSS files. Like here: https://github.com/oat-sa/tao-core/tree/master/views/scss/inc/solar
This would better scope the change and would ease later updates.
There was a problem hiding this comment.
This changes will replace original styles in the last development phases, so I decided to keep it by this manner.
Version
There are 0 BREAKING CHANGE, 8 features, 0 fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AUT-3941
Figma
Quick wins redesign, usability upgrades.
Feature flag is FEATURE_FLAG_QUICK_WINS_ENABLED