Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for https://github.com/thomseddon/koa-oauth-server/issues/29 #175

Merged
merged 2 commits into from
May 17, 2015
Merged

Fix for https://github.com/thomseddon/koa-oauth-server/issues/29 #175

merged 2 commits into from
May 17, 2015

Conversation

wehriam
Copy link
Contributor

@wehriam wehriam commented Apr 27, 2015

No description provided.

.set('Cache-Control', 'no-store')
.set('Pragma', 'no-cache')
.jsonp(response);
this.res.set({'Cache-Control':'no-store', 'Pragma': 'no-cache'});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing a single space :) Could it please be:

this.res.set({'Cache-Control': 'no-store', 'Pragma': 'no-cache'});

@thomseddon
Copy link
Member

Sorry for delay - could you add the extra space?

@wehriam
Copy link
Contributor Author

wehriam commented May 12, 2015

@thomseddon - Done.

@thomseddon thomseddon merged commit b0f84cb into oauthjs:master May 17, 2015
@thomseddon
Copy link
Member

Thanks 👍

@wehriam
Copy link
Contributor Author

wehriam commented Jun 22, 2015

@thomseddon could you do an incremental release to push this fix?

@thomseddon
Copy link
Member

Sorry will do

@thomseddon
Copy link
Member

Done in 2.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants