Test Commands for Windows #499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great. I had to do roughly the same thing to test on my Windows machine. |
|
Looks good, I've added a couple of reviews. Please could you address and then squash into a single commit |
thomseddon
requested changes
Aug 3, 2018
| @@ -56,7 +56,9 @@ | |||
| "scripts": { | |||
| "pretest": "./node_modules/.bin/jshint --config ./.jshintrc lib test", | |||
| "test": "NODE_ENV=test ./node_modules/.bin/mocha 'test/**/*_test.js'", | |||
| "test-debug": "NODE_ENV=test ./node_modules/.bin/mocha --inspect --debug-brk 'test/**/*_test.js'" | |||
| "test-windows": "set NODE_ENV=test&& node node_modules/mocha/bin/_mocha \"test\\**\\*_test.js\"", | |||
There was a problem hiding this comment.
Will this work with a space before the &&? If so, please add one
There was a problem hiding this comment.
cross-env NODE_ENV=test ./node_modules/.bin/mocha --inspect --debug-brk 'test/**/*_test.js'
suggestion cross-env
| "test-debug": "NODE_ENV=test ./node_modules/.bin/mocha --inspect --debug-brk 'test/**/*_test.js'" | ||
| "test-windows": "set NODE_ENV=test&& node node_modules/mocha/bin/_mocha \"test\\**\\*_test.js\"", | ||
| "test-debug": "NODE_ENV=test ./node_modules/.bin/mocha --inspect --debug-brk 'test/**/*_test.js'", | ||
| "test-windows-debug": "set NODE_ENV=test&& node node_modules/mocha/bin/_mocha --inspect --debug-brk \"test\\**\\*_test.js\"" |
There was a problem hiding this comment.
Same as above, if this works with a space before the &&, please add one
|
Two suggestions that might make it possible to have just a single
So the test commands might just look like this: {
"test": "npx mocha 'test/**/*_test.js'",
"test-debug": "npx mocha --inspect --debug-brk 'test/**/*_test.js'"
}Edit: NVM, 5.0 has more or less exactly this. 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I've just came across the fact that the npm test and npm run test-debug commands ain't working on a Windows Operating System and here is my Suggestion.
Greetings
Not Adrian