Skip to content

Commit

Permalink
Prevent test actions from outputting an extra execution graph node.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 570076051
Change-Id: I5ce0799463ca6b86f94302a9e887154260e4e077
  • Loading branch information
Googler authored and copybara-github committed Oct 2, 2023
1 parent 9757df9 commit c3260c4
Showing 1 changed file with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -699,6 +699,12 @@ void enqueue(Action action, long startMillis, long finishMillis) {
if (outputToNode.containsKey(getFirstOutput(action, action.getOutputs()))) {
return;
}
if (action.getMnemonic().equals("TestRunner")) {
// Test actions have a different primary output than their spawns, which would result in
// them recording an extra node. See b/290959382. Since test actions should always have/
// spawns, we can just skip them here.
return;
}
enqueue(actionToNode(action, startMillis, finishMillis).toByteArray());
}

Expand Down

0 comments on commit c3260c4

Please sign in to comment.