This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
[Issue 81] Python 3 version of Statsite Sink and Vagrant update #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix to get StatsD reporting to work - Python2 -> Python3 port of script from statsite
Fix to get StatsD reporting to work - related default Vagrant update to use the Python3 version of the statsite sink script
hkp
changed the title
deniszh
reviewed
Jul 13, 2020
| @@ -4,14 +4,49 @@ | |||
| # Vagrantfile API/syntax version. Don't touch unless you know what you're doing! | |||
| VAGRANTFILE_API_VERSION = "2" | |||
|
|
|||
| METRIC_SERVER_IP="10.0.1.110" | |||
There was a problem hiding this comment.
Are you sure that section is needed?
There was a problem hiding this comment.
This was for a code interview, so this is not needed for most people. I was setting up a multi-node environment and needed that variable so the nodes would know where to send the stats data.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synthesize wasn't working for master, v4.0.0 and v.3.0.1. I did a quick port of the Python 2 script since that was what the errors were about. I decided to add it to this repo, since I didn't know if statsite would take the Python3 script, but I know that synthesize is dependent on this. Added the related change to Vagrantfile, so it'll work from the current instructions.