Clarify caching inputs #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anything more I can do here? I'm assuming the failing CI tests are unrelated to my docs change. |
obi1kenobi
added a commit
that referenced
this pull request
Jul 2, 2024
It's always caching. Or DNS. This time it was caching. A while back, we changed the default cache key prefix from empty-string to `semver` so that our cache key names don't start with a dash, since users found that confusing. We should have updated these tests accordingly at the time, but we did not. So how did the PR with the change pass? It used the caches from older runs of the same job which used the old names. When those caches expired and were GC'd by GitHub, the jobs started failing. This is what broke CI for #77. This PR will fix it.
|
Indeed. Thanks for the ping! It's an interesting failure due to GitHub Actions caching that caused an older commit that should have failed CI to incorrectly pass CI by using a previous run's cache: After that PR merges, this CI should be green again. I'll keep an eye on it now and make sure it's all good. |
obi1kenobi
added a commit
that referenced
this pull request
Jul 2, 2024
It's always caching. Or DNS. This time it was caching. A while back, we changed the default cache key prefix from empty-string to `semver` so that our cache key names don't start with a dash, since users found that confusing. We should have updated these tests accordingly at the time, but we did not. So how did the PR with the change pass? It used the caches from older runs of the same job which used the old names. When those caches expired and were GC'd by GitHub, the jobs started failing. This is what broke CI for #77. This PR will fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation mentions
shared-keyandcache-keyas an input, but the latter doesn't seem to exist. I've changed the wording to refer toprefix-keyandshared-keyinstead.