Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supplying comma-separated features in the CLI doesn't work #915

Closed
obi1kenobi opened this issue Sep 5, 2024 · 1 comment · Fixed by #918
Closed

Supplying comma-separated features in the CLI doesn't work #915

obi1kenobi opened this issue Sep 5, 2024 · 1 comment · Fixed by #918
Assignees
@dmatos2012
Labels
C-bug Category: doesn't meet expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.

Comments

@obi1kenobi
Copy link
Owner

CLI args like --baseline-features 24bits,50bits,libm or --current-features 24bits,50bits,libm are interpreted as one long feature named "24bits,50bits,libm" instead of a comma-separated list of features.

I believe this is a divergence from how the cargo CLI handles features. Specifying the features one-at-a-time with a long CLI flag like --baseline-features is very clunky. We should support lists, and we should add CLI tests using the new testing framework to ensure this doesn't regress.

Bug noticed in #914 (comment)
@obi1kenobi obi1kenobi added C-bug Category: doesn't meet expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue. labels Sep 5, 2024
@obi1kenobi obi1kenobi mentioned this issue Sep 5, 2024
Open
@dmatos2012
Copy link
Contributor

This looks like easy(rip) :D, will give it a shot!

@dmatos2012 dmatos2012 mentioned this issue Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmatos2012 dmatos2012

Labels
C-bug Category: doesn't meet expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for specifying features with commas feat1,feat2 dmatos2012/cargo-semver-checks
2 participants
@obi1kenobi @dmatos2012