Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure passing "default" as a feature name is explicitly supported #916

Open
obi1kenobi opened this issue Sep 5, 2024 · 0 comments
Open
Labels
C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.

Comments

@obi1kenobi
Copy link
Owner

Passing --baseline-features default or --current-features default should be an explicit feature, since default features are just a feature named default that is enabled by convention.

This currently seems to work fine, but possibly equally due to luck as intent. I don't believe it's explicitly documented nor tested.

We want to test that feature-related invocations support and correctly interpret the default feature, and we want to explicitly call out this ability in the docs to make it easier to find.

Related to #915.

@obi1kenobi obi1kenobi added C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue. labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Development

No branches or pull requests

1 participant