Add vendored-openssl feature #324
Conversation
| @@ -41,3 +41,6 @@ toml = "0.5.9" | |||
| [dev-dependencies] | |||
| assert_cmd = "2.0" | |||
| lazy_static = "1.4.0" | |||
|
|
|||
| [features] | |||
| vendored-openssl = ["crates-index/vendored-openssl"] | |||
There was a problem hiding this comment.
Were you still planning on making this feature be default-enabled to preserve the current behavior, or did you change your mind on it again?
There was a problem hiding this comment.
Oh sorry, I forgot to make a commit for making it a default feature. Gimme a sec.
There was a problem hiding this comment.
Thanks for the reminder. adcf9ef
|
It seems #272 is no longer present in my local machine. I can't reproduce this issue, thus I can't test whether the feature works. :( |
|
Can you just update the top comment in the PR? When we merge, that's what will end up in the commit message, and it currently has incorrect information on whether this feature is on or off by default. |
Done. |
This PR adds a
vendored-openssldefault feature that enablesvendored-opensslincrates-indexdependency.Because there were some issues in the CI #208, there was a decision to enable by default the
vendored-opensslincargo-semver-checks, but lately there have been some issues with it in some users #272. Now a temporary fix for those users would be to disable default features incargo-semver-checks(thus disabling thevendored-opensslfeature). Because this project is a binary, not a library, we've decided to makevendored-openssla default feature so that users won't have to separately installopensslon their system.