Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lint: Pub module level static missing #496

Merged
merged 11 commits into from
Jul 15, 2023

Conversation

gliu20
Copy link
Contributor

@gliu20 gliu20 commented Jul 15, 2023

Implements the equivalent lint for public statics as was done for public consts. Note that per our discussion, we explicitly allow static to convert to const as there are instances where this is a non-breaking change.

edit: Addresses bullet point 2 of #366

@gliu20
Copy link
Contributor Author

gliu20 commented Jul 15, 2023

FYI I'm not sure if it's an issue on my side or with how github displays files, but VS Code (in Github Codespaces) shows that a trailing newline is present but the online viewer doesn't.

Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I have two tiny nits that should be fixable in just one minute or so, and this is good to merge!

src/lints/pub_module_level_static_missing.ron Outdated Show resolved Hide resolved
src/lints/pub_module_level_static_missing.ron Outdated Show resolved Hide resolved
@obi1kenobi
Copy link
Owner

FYI I'm not sure if it's an issue on my side or with how github displays files, but VS Code (in Github Codespaces) shows that a trailing newline is present but the online viewer doesn't.

At the moment I'm seeing all files ending with newlines. What does your editor show?

I'd assume the online viewer is authoritative since it's looking at the file state in the GitHub repo. But who knows! Weird bug, consider reporting it if you can reproduce it easily!

@obi1kenobi obi1kenobi enabled auto-merge (squash) July 15, 2023 18:01
Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied the last rename in the description and queued up for merging! 🚀

@gliu20
Copy link
Contributor Author

gliu20 commented Jul 15, 2023

Sweet!!!! Thanks again for the review and help!!! 🎉

@obi1kenobi obi1kenobi merged commit e880802 into obi1kenobi:main Jul 15, 2023
30 checks passed
@obi1kenobi
Copy link
Owner

Thanks to you for all the work you've put in, especially with all the thorough tests you've added. Teamwork makes the dream work! 🚀

@gliu20 gliu20 deleted the pub_module_level_static_missing branch July 15, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants