-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New lint: Pub module level static missing #496
New lint: Pub module level static missing #496
Conversation
FYI I'm not sure if it's an issue on my side or with how github displays files, but VS Code (in Github Codespaces) shows that a trailing newline is present but the online viewer doesn't. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I have two tiny nits that should be fixable in just one minute or so, and this is good to merge!
At the moment I'm seeing all files ending with newlines. What does your editor show? I'd assume the online viewer is authoritative since it's looking at the file state in the GitHub repo. But who knows! Weird bug, consider reporting it if you can reproduce it easily! |
Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied the last rename in the description and queued up for merging! 🚀
Sweet!!!! Thanks again for the review and help!!! 🎉 |
Thanks to you for all the work you've put in, especially with all the thorough tests you've added. Teamwork makes the dream work! 🚀 |
Implements the equivalent lint for
public static
s as was done forpublic const
s. Note that per our discussion, we explicitly allowstatic
to convert toconst
as there are instances where this is a non-breaking change.edit: Addresses bullet point 2 of #366