Fix occasional failure to generate rustdoc when RUSTFLAGS="-Dwarnings"
.
#643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating rustdoc JSON for a crate also involves checking that crate's dependencies. The check is done by rustc, not rustdoc, so it's subject to
RUSTFLAGS
notRUSTDOCFLAGS
. We don't want rustc to fail that check if the user has setRUSTFLAGS="-Dwarnings"
here.We resolve this by appending
--cap-lints=allow
toRUSTFLAGS
, which thankfully overrides prior lint-related commands like-Dwarnings
.Fixes: #589