New schema for attributes v23 (#5) #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial schema. * First version of changes in the adapter * Remove playground_test, add tests for attribute parsing. * Change &String to &str. * cargo fmt * Add as_string property to Attribute type. * Moved attributes-related code to separate module. * Fix the mistake in rustdoc_json_format_version test * Updated schema * Lower anyhow required version to match with cargo-semver-checks * Make adapter work with new names in schema * Simplify attributes parsing (not working yet...) * Fix lifetime and tests issues. * Clippy * Avoid copying AttributeValue's * Add Eq derivation, make messages in panics more descriptive. * Add test for parsing an improperly formatted attribute * Rename AttributeValue to AttributeMetaItem * Simplify slice_arguments * Minor changes in attributes tests, add test for unrecognized meta item * Rename AttributeMetaItem properties * Rename Attribute's as_string to raw_attribute * Cleaner formatting of error messages * Address problems with string literals inside attributes * More careful parsing of paths * Added a Polish pangram in a test * Keep trace of opened brackets. * Update src/attributes.rs * Update src/attributes.rs Co-authored-by: Tomasz Nowak <tomek.nowak.gm.16@gmail.com> Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial schema.
First version of changes in the adapter
Remove playground_test, add tests for attribute parsing.
Change &String to &str.
cargo fmt
Add as_string property to Attribute type.
Moved attributes-related code to separate module.
Fix the mistake in rustdoc_json_format_version test
Updated schema
Lower anyhow required version to match with cargo-semver-checks
Make adapter work with new names in schema
Simplify attributes parsing (not working yet...)
Fix lifetime and tests issues.
Clippy
Avoid copying AttributeValue's
Add Eq derivation, make messages in panics more descriptive.
Add test for parsing an improperly formatted attribute
Rename AttributeValue to AttributeMetaItem
Simplify slice_arguments
Minor changes in attributes tests, add test for unrecognized meta item
Rename AttributeMetaItem properties
Rename Attribute's as_string to raw_attribute
Cleaner formatting of error messages
Address problems with string literals inside attributes
More careful parsing of paths
Added a Polish pangram in a test
Keep trace of opened brackets.
Update src/attributes.rs
Update src/attributes.rs
Co-authored-by: Tomasz Nowak tomek.nowak.gm.16@gmail.com
Co-authored-by: Predrag Gruevski 2348618+obi1kenobi@users.noreply.github.com