Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Constant type/value properties (#280) #282

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

obi1kenobi
Copy link
Owner

  • add Constant property resolution function

allow reading constant value/expr/is_literal and type (this one serialized to a json string since there is no impl to convert it to FieldValue)

  • add Constant property rustdocs example

  • add Constant property rustdoc schema

  • dep: add serde_json for Constant property Type

  • fix clippy

  • uglify with rustfmt

  • Update src/rustdoc_schema.graphql

Co-authored-by: Predrag Gruevski 2348618+obi1kenobi@users.noreply.github.com

  • squeeze doc comment

  • add a doc comment note referencing a more comprehensive example

to avoid repeating said example

  • add type_ field to AssociatedConstant property resolution function

(temporary in the json string format)

  • add type_ field to AssociatedConstant property rustdoc schema

  • split schema docs so that each Constant property is documented

  • update schema doc comment

  • update schema docs trait name

  • fix a typo in schema docs

  • remove type Assoc/Const property

until trustfall adds proper support for custom scalar types

  • remove type Assoc/Const property from schema

  • fix a typo in schema docs

Co-authored-by: Predrag Gruevski 2348618+obi1kenobi@users.noreply.github.com

  • dep: remove serde_json since Constant property Type was removed

Co-authored-by: Predrag Gruevski 2348618+obi1kenobi@users.noreply.github.com

  • remove unstable rustdocs example for Constant properties

Co-authored-by: Predrag Gruevski 2348618+obi1kenobi@users.noreply.github.com

  • Update formatting of the schema docs

Co-authored-by: Predrag Gruevski 2348618+obi1kenobi@users.noreply.github.com

  • Update AssociatedConstant example to refer to a const generic

  • Update Constant test with extra properties

expr/value/is_literal


Co-authored-by: Predrag Gruevski 2348618+obi1kenobi@users.noreply.github.com

* add Constant property resolution function

allow reading constant value/expr/is_literal and type (this one serialized to a json string since there is no impl to convert it to FieldValue)

* add Constant property rustdocs example

* add Constant property rustdoc schema

* dep: add serde_json for Constant property Type

* fix clippy

* uglify with rustfmt

* Update src/rustdoc_schema.graphql

Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>

* squeeze doc comment

* add a doc comment note referencing a more comprehensive example

to avoid repeating said example

* add type_ field to AssociatedConstant property resolution function

(temporary in the json string format)

* add type_ field to AssociatedConstant property rustdoc schema

* split schema docs so that each Constant property is documented

* update schema doc comment

* update schema docs trait name

* fix a typo in schema docs

* remove type Assoc/Const property

until trustfall adds proper support for custom scalar types

* remove type Assoc/Const property from schema

* fix a typo in schema docs

Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>

* dep: remove serde_json since Constant property Type was removed

Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>

* remove unstable rustdocs example for Constant properties

Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>

* Update formatting of the schema docs

Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>

* Update AssociatedConstant example to refer to a const generic

* Update Constant test with extra properties

expr/value/is_literal

---------

Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
@obi1kenobi obi1kenobi enabled auto-merge (squash) October 9, 2023 04:02
@obi1kenobi obi1kenobi merged commit dc8d22b into rustdoc-v24 Oct 9, 2023
8 checks passed
@obi1kenobi obi1kenobi deleted the cp_rustdoc-v24_85a4470 branch October 9, 2023 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants