Support renaming re-exports, glob re-exports, and type aliases used as renames. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obi1kenobi
force-pushed
the
imports_test_suite
branch
8 times, most recently
from
d68682d to
599b107
Compare
obi1kenobi
force-pushed
the
imports_test_suite
branch
4 times, most recently
from
86901da to
4fffdeb
Compare
obi1kenobi
force-pushed
the
imports_test_suite
branch
6 times, most recently
from
538bbbd to
349bbcd
Compare
obi1kenobi
force-pushed
the
imports_test_suite
branch
from
349bbcd to
d3489f1
Compare
obi1kenobi
added a commit
that referenced
this pull request
Jan 27, 2023
…s renames. (#34) * Implement `pub use` and glob re-exports. * Reasonably handle import paths with cycles rather than crashing. * Handle `pub type` uses equivalent to `pub use` as mere re-exports. * Switch tests to nightly since that's where rustdoc v24 is.
obi1kenobi
added a commit
that referenced
this pull request
Jan 27, 2023
…s renames. (#34) * Implement `pub use` and glob re-exports. * Reasonably handle import paths with cycles rather than crashing. * Handle `pub type` uses equivalent to `pub use` as mere re-exports. * Switch tests to nightly since that's where rustdoc v24 is.
obi1kenobi
added a commit
that referenced
this pull request
Jan 27, 2023
…s renames. (#34) * Implement `pub use` and glob re-exports. * Reasonably handle import paths with cycles rather than crashing. * Handle `pub type` uses equivalent to `pub use` as mere re-exports. * Switch tests to nightly since that's where rustdoc v24 is.
This was referenced Mar 23, 2023
Merged
This was referenced Apr 14, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed one commit at a time:
type Foo = Barortype Foo<T> = Bar<T>, as opposed totype Foo = Bar<u64>which is not just a rename but also fills generic parameter slots.