Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize link protocol to lowercase so Android can recognize it #24

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Normalize link protocol to lowercase so Android can recognize it #24

merged 1 commit into from
Feb 27, 2018

Conversation

Ashoat
Copy link
Contributor

@Ashoat Ashoat commented Feb 19, 2018

Linking.canOpenURL on Android returns false if the protocol in your URL is not lowercase, eg. "HTtp://google.com". This PR makes sure the URL we pass Linking.canOpenURL always has a lowercased protocol.

@Ashoat
Copy link
Contributor Author

Ashoat commented Feb 19, 2018

Note that the mdurl library is already used by linkify-it, so this doesn't actually increase bundle size.

@obipawan
Copy link
Owner

Thanks for doing this @Ashoat. Much appreciated!

@obipawan obipawan merged commit 2492a2b into obipawan:master Feb 27, 2018
@obipawan
Copy link
Owner

Apologies for pushing this out so late.

This is available in v0.0.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ashoat @obipawan