-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
@maxonfjvipon could you check this one, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c71n93 Good one! Just a several comments from my side
if. > @ | ||
eq. | ||
value.as-bytes | ||
0.0.as-bytes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c71n93 let's make a minor optimization and replace 0.0.as-bytes
with 00-00-00...
. The same story with -0.0.as-bytes
below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c71n93 or at least you can cache 0.0.as-bytes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxonfjvipon done
@yegor256 could you check this one, please? |
@rultor merge |
Closes #146
PR-Codex overview
Focus of this PR:
This PR focuses on adding new methods to the
number
class in themath
package. These methods check if a number is equal to zero, whether it is an integer or a float, and if it is NaN.Detailed summary:
is-int-zero
to check if a number is an integer zero.is-float-zero
to check if a number is a floating-point zero.is-nan
to check if a number is NaN.