Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Accordion content blinking #475

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

truph01
Copy link
Contributor

@truph01 truph01 commented Jun 21, 2024

Screen.Recording.2024-06-21.at.15.51.17.mov

@truph01
Copy link
Contributor Author

truph01 commented Jun 21, 2024

@oblador Can you help review this PR once you have a chance? Thanks

Collapsible.js Outdated Show resolved Hide resolved
@oblador
Copy link
Owner

oblador commented Jul 1, 2024

Hi, thanks for your PR! When I tested there's still junk on Android (iOS looks fine from what I can tell):

jank.mov

@truph01
Copy link
Contributor Author

truph01 commented Jul 2, 2024

@Pujan92 Can you reproduce the issue on Android after applying the fix? It works well from my side:

Screen.Recording.2024-07-02.at.10.08.17.mov

@Pujan92
Copy link

Pujan92 commented Jul 2, 2024

It works well for me too. @oblador Could you plz check one more time on your side?

Before After Fix
Screen.Recording.2024-07-02.at.11.59.26.mov
after_fix.mov

@Pujan92
Copy link

Pujan92 commented Jul 9, 2024

Gentle bump for recheck @oblador

@Pujan92
Copy link

Pujan92 commented Jul 9, 2024

Tried the example code with the functional component and was not able to reproduce the mentioned bug for android.

abcd.mp4

@truph01
Copy link
Contributor Author

truph01 commented Jul 22, 2024

@oblador Can you help review the PR? Thanks

@truph01
Copy link
Contributor Author

truph01 commented Aug 20, 2024

@oblador Any update on the PR review?

Thx

@oblador oblador force-pushed the fix/473/accordion-content-blinking branch from 2c5aacb to 9f285f8 Compare August 27, 2024 19:51
@oblador oblador merged commit 8644394 into oblador:master Aug 27, 2024
1 check passed
@Pujan92
Copy link

Pujan92 commented Aug 28, 2024

Thanks @oblador for the review and merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants