Fixing black color fill for react-native-web and showing text percentage of filled circle. #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oblador
reviewed
Jan 26, 2023
| @@ -203,7 +204,7 @@ export class ProgressCircle extends Component { | |||
| ]} | |||
| allowFontScaling={allowFontScaling} | |||
| > | |||
| {formatText(progressValue)} | |||
| {progress ? formatText(progress._value) : this.forceUpdate()} | |||
There was a problem hiding this comment.
Why is this needed? Calling this.forceUpdate() from the render function might cause an infinite loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fill={fill} will change the color inside the circle for react-native-web and we need to pass fill='
#00000000' from the frontend. This text change will show the correct percentage of the filled circle.